-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add message when no contexts are found in kubeconfig #259
base: master
Are you sure you want to change the base?
Conversation
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
You need to implement integration tests as well I believe. |
c71a300
to
03be094
Compare
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
@googlebot I fixed it |
test case 17, delete several contexts validates this, I've updated the test case. Should I still write a separate test for this? |
you're right it's technically capturing this case, but it's more ideal if we copy-paste it into its own test case. technically we want to have 1:1 mapping between "behavior we want to test" and "integration test case". |
See the proposal here
What did I do?